fix(isInt, isFloat): Handle undefined and null values #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubiin
approved these changes
Jun 7, 2024
Contributor
Author
|
Hi @profnandaa, |
profnandaa
approved these changes
Jun 22, 2024
Member
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix! 🎉
|
Hi @profnandaa will it be part of a release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced both the 'isInt' and 'isFloat' functions by incorporating checks for null and undefined values, enabling them to handle cases where the input may be null or undefined
Issue Referenced
#2328
Checklist