Skip to content

Conversation

@nimanthadilz
Copy link
Contributor

Added LK locale to isPostalCode validator. Tests are provided.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1788 (8201312) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1788   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isPostalCode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...8201312. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your PR @nimanthadilz 🎉
Is your contribution as part of Hacktoberfest?

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 25, 2021
@nimanthadilz
Copy link
Contributor Author

@tux-tn Yes. I did this contribution as part of Hacktoberfest.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 8451206 into validatorjs:master Oct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
* Add `LK` locale to `isPostalCode`

* Add tests for `LK` locale of `isPostalCode`

* Update README.md
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* Add `LK` locale to `isPostalCode`

* Add tests for `LK` locale of `isPostalCode`

* Update README.md
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* Add `LK` locale to `isPostalCode`

* Add tests for `LK` locale of `isPostalCode`

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants