bugfix(isMobilePhone.js): Updating regex of Belgium and the valid and invalid phone numbers in validators.js #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tux-tn
requested changes
Oct 2, 2021
Member
tux-tn
left a comment
There was a problem hiding this comment.
Thank you @divikshrivastava and congrats for your first PR here 👏
Your tests are not passing, can you please fix that?
Contributor
Author
|
…js since phone number rules will be same for that too
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2015 2015
Branches 454 454
=========================================
Hits 2015 2015
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Oct 2, 2021
Member
tux-tn
left a comment
There was a problem hiding this comment.
LGTM 🎉
Is your participation as part of hacktoberfest ?
Contributor
Author
|
Yes sir! @tux-tn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the updation of regex for Belgian's mobile number validation (nl-BE), along with correction of valid and invalid numbers in validators.js
Checklist