feat(isMobilePhone): add ar-MA locale #1521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1521 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1286 1286
=======================================
Hits 1285 1285
Misses 1 1
Continue to review full report at Codecov.
|
ezkemboi
reviewed
Nov 15, 2020
| 'ar-JO': /^(\+?962|0)?7[789]\d{7}$/, | ||
| 'ar-KW': /^(\+?965)[569]\d{7}$/, | ||
| 'ar-LY': /^((\+?218)|0)?(9[1-6]\d{7}|[1-8]\d{7,9})$/, | ||
| 'ar-MA': /^(?:(?:\+|00)212|0)[5-7]\d{8}$/, |
Member
There was a problem hiding this comment.
Please add tests for this change.
ezkemboi
approved these changes
Nov 16, 2020
Member
ezkemboi
left a comment
There was a problem hiding this comment.
Just fix conflicts and this is good.
profnandaa
approved these changes
Nov 17, 2020
Member
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉
|
Thank you 👍 |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ar-MA locale to validate Moroccan mobile phones.
Checklist