Skip to content

feat: add node-redis driver (#664) #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add node-redis driver (#664) #665

wants to merge 1 commit into from

Conversation

@cjpearson
Copy link
Contributor

@cjpearson cjpearson commented Aug 27, 2025 •
edited
Loading

#664

This adds a new driver for redis using the node-redis library.

It's mostly based off of the existing redis driver which uses ioredis. But there are a few differences:

@cjpearson cjpearson requested a review from pi0 as a code owner August 27, 2025 16:03
@cjpearson cjpearson marked this pull request as draft August 27, 2025 16:04
@codecov
Copy link

codecov bot commented Aug 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 99.33775% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.81%. Comparing base (70310f9) to head (50368e5).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/node-redis.ts 99.32% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   59.99%   63.81%   +3.81%     
==========================================
  Files          42       44       +2     
  Lines        3657     4043     +386     
  Branches      590      701     +111     
==========================================
+ Hits         2194     2580     +386     
  Misses       1460     1460              
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cjpearson cjpearson force-pushed the node-redis-driver branch 3 times, most recently from bbdd31a to 2de074e Compare August 28, 2025 15:49
@cjpearson cjpearson marked this pull request as ready for review August 28, 2025 15:54
@cjpearson cjpearson force-pushed the node-redis-driver branch 3 times, most recently from f987c71 to dbc4752 Compare September 3, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 Awaiting requested review from pi0 pi0 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cjpearson