refactor(typescript-estree): simplify applyModifiersToResult #3084
Conversation
|
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3084 +/- ##
==========================================
- Coverage 92.83% 92.83% -0.01%
==========================================
Files 314 314
Lines 10675 10671 -4
Branches 3027 3027
==========================================
- Hits 9910 9906 -4
Misses 348 348
Partials 417 417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Those changes has been extracted from #3078
simplifies logic used to generate deprecated
modifiersfield in some of nodes. instead of iterating over nodes collecting results, filtering them and mapping them again we perform entire operation in first loopthis change has negligible perf improvement