chore(eslint-plugin): correct TODO comment on the wrong line #11773
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove TODO and update comments related to `no-new-symbol` rule. The `no-new-symbol` rule was deprecated in ESLint 9.0.0 and will be removed in ESLint v11.0.0. We need to keep the rule disabled until TSESLint drops support for ESLint 8. (This commit message was automatically generated by an LLM.)
Contributor
|
Thanks for the PR, @Zamiell! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit e3158a3
☁️ Nx Cloud last updated this comment at |
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11773 +/- ##
==========================================
- Coverage 90.52% 90.49% -0.04%
==========================================
Files 522 522
Lines 53356 53357 +1
Branches 8920 8909 -11
==========================================
- Hits 48300 48284 -16
- Misses 5040 5057 +17
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
d26e9de
into
typescript-eslint:main
65 of 66 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the TODO comment in this file was actually in the wrong spot, implying that "no-new-native-nonconstructor" was the deprecated rule instead of "no-new-symbol".
I moved the comment, and then expanded it to make it more descriptive.