Skip to content

feat(typescript-estree): replace fast-glob with tinyglobby #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 3 commits into from
Nov 24, 2025
Merged

feat(typescript-estree): replace fast-glob with tinyglobby #11740

JoshuaKGoldberg merged 3 commits into from
Nov 24, 2025

Conversation

@benmccann
Copy link
Contributor

@benmccann benmccann commented Nov 3, 2025 •
edited
Loading

PR Checklist

Overview

Replaces fast-glob with tinyglobby for a smaller more efficient implementation with fewer dependencies

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 3, 2025

Thanks for the PR, @benmccann!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 3, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2ff3092
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6924598808234f000780ce0a
😎 Deploy Preview https://deploy-preview-11740--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Nov 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2ff3092

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 12s View ↗
nx run-many -t lint ✅ Succeeded 3m 16s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 16s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 12s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-24 13:29:18 UTC

@benmccann benmccann force-pushed the tinyglobby-2025 branch 6 times, most recently from 31b9ae9 to e34be70 Compare November 3, 2025 16:21
@benmccann benmccann marked this pull request as ready for review November 3, 2025 16:30
@benmccann benmccann mentioned this pull request Nov 3, 2025
Closed
4 tasks
@codecov
Copy link

codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.52%. Comparing base (c7119b5) to head (2ff3092).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11740   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         522      522           
  Lines       53353    53356    +3     
  Branches     8921     8920    -1     
=======================================
+ Hits        48296    48300    +4     
  Misses       5040     5040           
+ Partials       17       16    -1
Flag Coverage Δ
unittest 90.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ipt-estree/src/parseSettings/resolveProjectList.ts 100.00% <100.00%> (+1.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did some preliminary testing and it seems to work well. I'll want to spend some time -ideally later this week, TBD- testing it a bit more thoroughly just to be safe. But tentatively ✅ from me!

Just a couple of small comments, nothing we can't touch up before merge.

Thanks for jumping on this!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 10, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: replace fast-glob with tinyglobby fix(typescript-estree): replace fast-glob with tinyglobby Nov 17, 2025
bradzacher
bradzacher previously approved these changes Nov 23, 2025
View reviewed changes
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 23, 2025
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 23, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! I played around with this a bunch locally and couldn't break anything. This is looking lovely. Thanks a bunch @benmccann for authoring this, and @benmccann + @43081j + everyone else who advocated for the smaller package in #10533. 🚢 !

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(typescript-estree): replace fast-glob with tinyglobby feat(typescript-estree): replace fast-glob with tinyglobby Nov 24, 2025
@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from bradzacher and themself via c2a1e8a November 24, 2025 12:57
@JoshuaKGoldberg JoshuaKGoldberg merged commit a915893 into typescript-eslint:main Nov 24, 2025
65 of 66 checks passed
@benmccann benmccann deleted the tinyglobby-2025 branch November 24, 2025 14:29
@chrisbbreuer chrisbbreuer mentioned this pull request Nov 24, 2025
Open
1 task
@HolgerJeromin HolgerJeromin mentioned this pull request Nov 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@bradzacher bradzacher bradzacher left review comments

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benmccann @JoshuaKGoldberg @bradzacher