fix(eslint-plugin): [consistent-generic-constructors] ignore when constructor is typed array #10477

mdm317 · 2024-12-09T09:33:15Z

PR Checklist

Addresses an existing open issue: fixes Bug: [consistent-generic-constructors] improper fix into new Uint8Array<ArrayBufferLike>() #10445
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Hard-code the typed arrays and added code to skip check if the type is a typed array.

typescript-eslint · 2024-12-09T09:33:18Z

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

nx-cloud · 2024-12-09T09:34:10Z

View your CI Pipeline Execution ↗ for commit 2bd81ac

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 15s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 11s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 6s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	6s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-03 22:52:07 UTC

netlify · 2024-12-09T09:34:17Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`2bd81ac`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/69092f4243a5270008a2587d
😎 Deploy Preview	https://deploy-preview-10477--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2024-12-09T09:49:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (ea2ee6b) to head (2bd81ac).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10477   +/-   ##
=======================================
  Coverage   90.66%   90.67%           
=======================================
  Files         518      518           
  Lines       52435    52456   +21     
  Branches     8686     8688    +2     
=======================================
+ Hits        47541    47562   +21     
  Misses       4880     4880           
  Partials       14       14

Flag	Coverage Δ
unittest	`90.67% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts	`97.48% <100.00%> (+0.38%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts

JoshuaKGoldberg

A good start! 🚀

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts

Josh-Cena · 2024-12-17T02:34:58Z

FWIW, my personal preference is still "we should not special case built-ins". These types of declarations can legitimately happen with user-defined types, so we should just create a generic allowlist of types.

mdm317 · 2024-12-17T16:35:20Z

Should we avoid dealing specifically with the built-in array-likes?

JoshuaKGoldberg · 2025-01-13T01:05:42Z

@Josh-Cena just confirming, what do you suggest we do here?

Josh-Cena · 2025-02-24T15:59:34Z

This:

we should just create a generic allowlist of types.

Like a new option called ignore or allow where the types would just be ignored for consistency checks.

This reverts commit 34f390c.

This reverts commit 2e75e31.

…sistent-generic-constructors

mdm317 · 2025-03-14T17:19:36Z

Like a new option called ignore or allow where the types would just be ignored for consistency checks.

I added an allow option to ignore consistency checks.

Should I add TypedArray to the default option?

JoshuaKGoldberg

Sorry for the back-and-forth on this rule's option(s)! It looks like we have a bit of design/discussion work to do before we're settled?

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts

JoshuaKGoldberg · 2025-09-22T16:23:59Z

@mdm317 sorry for the delay on this! I think there's consensus on what to do in #10477 (comment). Is there anything else blocking you on this PR?

…sistent-generic-constructors

mdm317 · 2025-09-23T14:56:01Z

@JoshuaKGoldberg
All good, no blockers. Appreciate you driving the consensus, I’ll resolve the merge conflicts on my side.

JoshuaKGoldberg

Current status is waiting on:

Having the known "can't be fixed" built-in lib types always be allowed
Implementing the TypeOrValueSpecifier change

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts

JoshuaKGoldberg · 2025-11-03T22:39:51Z

Ok, looking back at this, I figured out the discrepancy - we'd only 👍d hardcoding the known built-in array classes as ignored. Adding a TypeOrValueSpecifier ignore option is out-of-scope because that format requires type information. This rule isn't typed right now.

Sorry for the confusion. I updated the code to just hardcode allowing the types mentioned in https://github.com/microsoft/TypeScript/pull/59417/files.

I updated the code myself.

@dbarabashh

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.47.0 | 8.48.0 | | npm | @typescript-eslint/parser | 8.47.0 | 8.48.0 | ## [v8.48.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8480-2025-11-24) ##### 🚀 Features - **eslint-plugin:** \[no-redundant-type-constituents] use assignability checking for redundancy checks ([#10744](typescript-eslint/typescript-eslint#10744)) ##### 🩹 Fixes - **typescript-estree:** disallow binding patterns in parameter properties ([#11760](typescript-eslint/typescript-eslint#11760)) - **eslint-plugin:** \[consistent-generic-constructors] ignore when constructor is typed array ([#10477](typescript-eslint/typescript-eslint#10477)) ##### ❤️ Thank You - Dima Barabash [@dbarabashh](https://github.com/dbarabashh) - JamesHenry [@JamesHenry](https://github.com/JamesHenry) - Josh Goldberg - mdm317 [@gen-ip-1](https://github.com/gen-ip-1) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@dbarabashh

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.47.0 | 8.48.0 | | npm | @typescript-eslint/parser | 8.47.0 | 8.48.0 | ## [v8.48.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8480-2025-11-24) ##### 🚀 Features - **eslint-plugin:** \[no-redundant-type-constituents] use assignability checking for redundancy checks ([#10744](typescript-eslint/typescript-eslint#10744)) ##### 🩹 Fixes - **typescript-estree:** disallow binding patterns in parameter properties ([#11760](typescript-eslint/typescript-eslint#11760)) - **eslint-plugin:** \[consistent-generic-constructors] ignore when constructor is typed array ([#10477](typescript-eslint/typescript-eslint#10477)) ##### ❤️ Thank You - Dima Barabash [@dbarabashh](https://github.com/dbarabashh) - JamesHenry [@JamesHenry](https://github.com/JamesHenry) - Josh Goldberg - mdm317 [@gen-ip-1](https://github.com/gen-ip-1) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.47.0` -> `8.48.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.47.0/8.48.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.47.0/8.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.47.0` -> `8.48.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.47.0/8.48.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.47.0/8.48.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v8.48.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8481-2025-12-02) [Compare Source](typescript-eslint/typescript-eslint@v8.48.0...v8.48.1) ##### 🩹 Fixes - **eslint-plugin:** \[restrict-template-expressions] check base types in allow list ([#11764](typescript-eslint/typescript-eslint#11764), [#11759](typescript-eslint/typescript-eslint#11759)) - **eslint-plugin:** honor ignored base types on generic classes ([#11767](typescript-eslint/typescript-eslint#11767)) - **eslint-plugin:** \[consistent-type-exports] check value flag before resolving alias ([#11769](typescript-eslint/typescript-eslint#11769)) ##### ❤️ Thank You - Josh Goldberg - OleksandraKordonets - SangheeSon [@Higangssh](https://github.com/Higangssh) - tao You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.48.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8480-2025-11-24) [Compare Source](typescript-eslint/typescript-eslint@v8.47.0...v8.48.0) ##### 🚀 Features - **eslint-plugin:** \[no-redundant-type-constituents] use assignability checking for redundancy checks ([#10744](typescript-eslint/typescript-eslint#10744)) ##### 🩹 Fixes - **typescript-estree:** disallow binding patterns in parameter properties ([#11760](typescript-eslint/typescript-eslint#11760)) - **eslint-plugin:** \[consistent-generic-constructors] ignore when constructor is typed array ([#10477](typescript-eslint/typescript-eslint#10477)) ##### ❤️ Thank You - Dima Barabash [@dbarabashh](https://github.com/dbarabashh) - JamesHenry [@JamesHenry](https://github.com/JamesHenry) - Josh Goldberg - mdm317 [@gen-ip-1](https://github.com/gen-ip-1) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v8.48.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8481-2025-12-02) [Compare Source](typescript-eslint/typescript-eslint@v8.48.0...v8.48.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ### [`v8.48.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8480-2025-11-24) [Compare Source](typescript-eslint/typescript-eslint@v8.47.0...v8.48.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/57 Co-authored-by: Renovate Bot <renovate@csmpro.ru> Co-committed-by: Renovate Bot <renovate@csmpro.ru>

fix: ignore when constructor is typed array

2e75e31

mdm317 marked this pull request as draft December 9, 2024 09:33

mdm317 marked this pull request as ready for review December 9, 2024 15:56

JoshuaKGoldberg reviewed Dec 14, 2024

View reviewed changes

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg requested changes Dec 14, 2024

View reviewed changes

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 14, 2024

mdm317 added 2 commits December 16, 2024 23:24

fix: redeclare their own class

34f390c

Merge branch 'main' into fix/issue-10445-consistent-generic-constructors

845a74b

mdm317 requested a review from JoshuaKGoldberg December 17, 2024 16:31

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 17, 2024

JoshuaKGoldberg changed the title ~~fix: ignore when constructor is typed array~~ fix(eslint-plugin): [consistent-generic-constructors] ignore when constructor is typed array Jan 13, 2025

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 3, 2025

mdm317 added 8 commits March 13, 2025 00:26

Revert "fix: redeclare their own class"

d3fd541

This reverts commit 34f390c.

Revert "fix: ignore when constructor is typed array"

7613753

This reverts commit 2e75e31.

feat : add ignoreConstructors option

d331b1f

Merge remote-tracking branch 'upstream/main' into fix/issue-10445-con…

013fd02

…sistent-generic-constructors

chore : change snapshot

f3c37b1

doc : add option description

82e9dfb

doc : change text

e32fec8

typo : ignoreConstructor to ignore

91b65ae

JoshuaKGoldberg requested changes Mar 31, 2025

View reviewed changes

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the triage Waiting for team members to take a look label Mar 31, 2025

JoshuaKGoldberg removed the triage Waiting for team members to take a look label Sep 22, 2025

Merge remote-tracking branch 'upstream/main' into fix/issue-10445-con…

311b5aa

…sistent-generic-constructors

fix : docs

d81301a

mdm317 requested a review from JoshuaKGoldberg September 24, 2025 15:34

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 24, 2025

JoshuaKGoldberg previously requested changes Oct 3, 2025

View reviewed changes

packages/eslint-plugin/src/rules/consistent-generic-constructors.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 3, 2025

JoshuaKGoldberg added 2 commits November 3, 2025 17:08

Merge branch 'main' into fix/issue-10445-consistent-generic-constructors

1e2aabb

Remove allowlist altogether

2bd2fc7

Update test snapshots

2bd81ac

JoshuaKGoldberg requested a review from a team November 3, 2025 22:42

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 3, 2025

bradzacher approved these changes Nov 23, 2025

View reviewed changes

bradzacher merged commit 5ea21f1 into typescript-eslint:main Nov 23, 2025
66 of 67 checks passed

chrisbbreuer mentioned this pull request Nov 24, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

Uh oh!

fix(eslint-plugin): [consistent-generic-constructors] ignore when constructor is typed array #10477

fix(eslint-plugin): [consistent-generic-constructors] ignore when constructor is typed array #10477

Conversation

mdm317 commented Dec 9, 2024

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Dec 9, 2024

Uh oh!

nx-cloud bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

codecov bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Josh-Cena commented Dec 17, 2024

Uh oh!

mdm317 commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jan 13, 2025

Uh oh!

Josh-Cena commented Feb 24, 2025

Uh oh!

mdm317 commented Mar 14, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Sep 22, 2025

Uh oh!

mdm317 commented Sep 23, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nx-cloud bot commented Dec 9, 2024 •

edited

Loading

netlify bot commented Dec 9, 2024 •

edited

Loading

codecov bot commented Dec 9, 2024 •

edited

Loading

mdm317 commented Dec 17, 2024 •

edited

Loading