Skip to content

Conversation

@antonioperic
Copy link
Contributor

No description provided.

@antonioperic
Copy link
Contributor Author

@kayladnls can we merge this please?

@greydnls
Copy link
Contributor

@antonioperic looks good. I'll be happy to merge, but can we get some tests to cover the new functionality, please?

@antonioperic
Copy link
Contributor Author

@kayladnls I promise I will add test, but now I need it for completing project. If you can merge I will deliver test until end of week. :)

@greydnls
Copy link
Contributor

I'm sorry, I really can't merge without a test. I'll see if I can get the tests written this evening and merge it in the morning.

@antonioperic
Copy link
Contributor Author

@kayladnls ok, if you can do that it will be awesome

@antonioperic
Copy link
Contributor Author

@kayladnls did you manage to work on this?
thnx

@antonioperic
Copy link
Contributor Author

@kayladnls hi, I added Cpautre, Annul, Credit request and covered with tests, please merge this, it is very important for one of project I am working on. If need something to change, please let me know

src/Gateway.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to stay in line with the rest of Omnipay, this would need to be void()

@greydnls
Copy link
Contributor

greydnls commented May 8, 2015

@antonioperic This looks great, and that you very much for all the work on it. Just that one verbiage change on the Annul request. I'll merge it as soon as that's done.

@antonioperic
Copy link
Contributor Author

@kayladnls i am not sure I am following you

@greydnls
Copy link
Contributor

greydnls commented May 8, 2015

Omnipay keeps a consistent API across all gateways. So, what netaxept calls annul, we would call void. You would need to update that function on this gateway to reflect the consistent api.

#4 (comment)

@antonioperic
Copy link
Contributor Author

@kayladnls is now ok?

@greydnls
Copy link
Contributor

greydnls commented May 8, 2015

Yup, waiting on Travis and I'll tag a new minor.

greydnls added a commit that referenced this pull request May 8, 2015
@greydnls greydnls merged commit a15ab75 into thephpleague:master May 8, 2015
@antonioperic
Copy link
Contributor Author

thnx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants