-
Notifications
You must be signed in to change notification settings - Fork 12
Adding capture option #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kayladnls can we merge this please? |
|
@antonioperic looks good. I'll be happy to merge, but can we get some tests to cover the new functionality, please? |
|
@kayladnls I promise I will add test, but now I need it for completing project. If you can merge I will deliver test until end of week. :) |
|
I'm sorry, I really can't merge without a test. I'll see if I can get the tests written this evening and merge it in the morning. |
|
@kayladnls ok, if you can do that it will be awesome |
|
@kayladnls did you manage to work on this? |
|
@kayladnls hi, I added Cpautre, Annul, Credit request and covered with tests, please merge this, it is very important for one of project I am working on. If need something to change, please let me know |
src/Gateway.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to stay in line with the rest of Omnipay, this would need to be void()
|
@antonioperic This looks great, and that you very much for all the work on it. Just that one verbiage change on the Annul request. I'll merge it as soon as that's done. |
|
@kayladnls i am not sure I am following you |
|
Omnipay keeps a consistent API across all gateways. So, what netaxept calls |
|
@kayladnls is now ok? |
|
Yup, waiting on Travis and I'll tag a new minor. |
|
thnx |
No description provided.