Skip to content

Conversation

@wnugent
Copy link
Contributor

@wnugent wnugent commented May 3, 2025

No description provided.

@wnugent wnugent requested review from a team, ayushmjain, imrannayer and q2w as code owners May 3, 2025 10:04
@google-cla
Copy link

google-cla bot commented May 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@AaronBandt
Copy link

@wnugent Are you able to complete the steps to sign the CLA? I'm very interested in this feature and would like to see it merged as soon as possible.

@wnugent
Copy link
Contributor Author

wnugent commented May 16, 2025

@wnugent Are you able to complete the steps to sign the CLA? I'm very interested in this feature and would like to see it merged as soon as possible.

@AaronBandt I have signed the CLA already but i just noticed the linting step is failing, i've pushed a fix there that should resolve it

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

imrannayer commented May 19, 2025

@wnugent thx for the PR. Can you plz update versions.tf file and set min provider to 6.17 since this feature was released as part of 6.17?
This will be a breaking change. Can you also add a document in docs folder for next release V26.

@imrannayer imrannayer self-assigned this May 19, 2025
@imrannayer imrannayer changed the title feat: Adding new variables to define failover dr replica feat(TPG>6.17)!: Adding new variables to define failover dr replica May 19, 2025
@wnugent wnugent force-pushed the dr-replica-configuration branch from 32c61fc to d7e751f Compare May 19, 2025 19:41
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer self-requested a review May 21, 2025 13:24
@imrannayer imrannayer merged commit 90a3e64 into terraform-google-modules:main May 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants