Reject request if creating custom OTEL tracer fails #4476
+28
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a custom tracer can be required for traces to be correctly exported (e.g. with Arize), so an error creating a custom tracer might only ever show up in the logs. Let's reject the request when this happens, instead of continuing on and potentially failing to export the inference trace to OTEL.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the OpenTelemetry tracing middleware by converting silent error logging to proper error propagation. When custom tracer creation or HTTP span creation fails, the errors are now returned to the caller instead of being logged and ignored.
- Changed
get_or_create_custom_tracerto returnResult<Context, Error>instead ofContext - Changed
make_otel_http_spanto returnResult<Span, Error>instead ofSpan - Updated error handling in
tensorzero_otel_tracing_middlewareto properly propagate errors from span creation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
virajmehta
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a custom tracer can be required for traces to be correctly exported (e.g. with Arize), so an error creating a custom tracer might only ever show up in the logs. Let's reject the request when this happens, instead of continuing on and potentially failing to export the inference trace to OTEL.
Important
Reject requests if creating a custom OTEL tracer fails, ensuring proper trace exportation handling.
get_or_create_custom_tracerinTracerWrappernow returnsResult<Context, Error>instead ofContext.make_otel_http_spannow returnsResult<Span, Error>and handles errors by rejecting requests if custom tracer creation fails.tensorzero_otel_tracing_middlewareupdated to reject requests ifmake_otel_http_spanreturns an error.make_otel_http_span.map_errto handle errors inget_or_create_custom_tracer.mod.rsto support new error handling logic.This description was created by
for 59e7878. You can customize this summary. It will automatically update as commits are pushed.