Remove smooth scrolling in profiles when "Interface Animations" setting is disabled #30034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling "Interface Animations" option in battery settings does not disable the smooth scrolling in profiles. Experimental option "Use legacy scroll processing in profiles" does not disable it either. Smooth scrolling is not present in any other scrollable interface element except for just profiles, which makes it inconsistent across the application. ## Expected behavior Disabling "Interface animations" also should disable smooth scrolling in profiles. ## Factual behavior Smooth scrolling in profiles is unaffected by any setting. ## Implementation Disable smooth scrolling animation in profile pages when Interface Animations setting is turned off in battery saving settings. The fix checks anim::Disabled() before starting scroll animations in setupScrollHandling() and setupScrollHandlingWithFilter() methods, making profile scrolling behavior consistent with other interface elements.
|
|
Contributor
Yeah, looks like it just switches between different smooth scroll impls |
Collaborator
|
I would say, if we want to disable the smooth scrolling, we should check if (AlternativeScrollProcessing.value()) {
setupScrollHandling();
} else {
setupScrollHandlingWithFilter();
} |
Author
sounds valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabling
"Interface Animations"option in battery settings does not disable the smooth scrolling in profiles. experimental option"Use legacy scroll processing in profiles"does not disable it either. smooth scrolling is not present in any other scrollable interface element except for just profiles, which makes it inconsistent across the applicationExpected behavior
disabling "Interface animations" also should disable smooth scrolling in profiles
Factual behavior
smooth scrolling in profiles is unaffected by any setting
Implementation
disable smooth scrolling animation in profile pages when
Interface Animationssetting is turned off in battery saving settings. the fix checksanim::Disabled()before starting scroll animations insetupScrollHandling()andsetupScrollHandlingWithFilter()methodsi have reviewed how the check for disabled
Interface Animationsis implemented in other parts of the source code to make sure that my changes are consistent with the already existing patterns, and it was, in fact, a simple "if else" check foranim::Disabled(), so i did just that