Skip to content

Conversation

@pinbraerts
Copy link

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

@ilya-fedin
Copy link
Contributor

There seem to be spacing problems looking at the diff with GitHub UI...

Command::ChatNext,
Command::ChatFirst,
Command::ChatLast,
Command::ChatScrollDown,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

MediaPrevious,
MediaNext,

ChatScrollDown,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ilya-fedin
Copy link
Contributor

history_widget.cpp is still not fixed...

@pinbraerts
Copy link
Author

history_widget.cpp is still not fixed...

done

@pinbraerts
Copy link
Author

Maybe I missed something. Are there an .editorconfig or .clang-format files somewhere?

@ilya-fedin
Copy link
Contributor

Are there an .editorconfig or .clang-format files somewhere?

no

@ilya-fedin
Copy link
Contributor

Can you squash the commits?

@pinbraerts pinbraerts changed the title Add scroll actions feat(keyboards): add shortcuts for scrolling chat Aug 21, 2024
@pinbraerts
Copy link
Author

Can you squash the commits?

done

{ u"search"_q , Command::Search },

{ u"previous_chat"_q , Command::ChatPrevious },
{ u"next_chat"_q , Command::ChatNext },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is well to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants