Fixes #88 #92
Draft
Fixes #88 #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@aralroca While I think (barely) understand teaful's design, I'm lost in applying the new hook. Any guidance? |
aralroca
reviewed
Aug 4, 2022
Collaborator
aralroca
left a comment
There was a problem hiding this comment.
Thanks! I think it's perfect to implement it with useSyncExternalStore, it's something I was looking to do some time ago but I got stuck half way. Any idea how it should be implemented?
Author
|
@aralroca Take a look at https://gist.github.com/mrclay/6ad71d1993e5d97e11aff1285c67eaf6 for a crude partial implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Require React 18, use useSyncExternalStore for more reliable subscription.
Which issue (if any) does this pull request address?
#88
Is there anything you'd like reviewers to focus on?