-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[JsonStreamer] fix invalid json output for list of self #62622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2354b64 to
da16299
Compare
stof
reviewed
Dec 2, 2025
mtarld
requested changes
Dec 2, 2025
src/Symfony/Component/JsonStreamer/Tests/JsonStreamWriterTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/JsonStreamWriterTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Write/StreamWriterGeneratorTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Write/StreamWriterGeneratorTest.php
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Fixtures/Model/SelfReferencingDummyList.php
Outdated
Show resolved
Hide resolved
e7bb0b2 to
f064edc
Compare
mtarld
reviewed
Dec 2, 2025
src/Symfony/Component/JsonStreamer/Tests/JsonStreamWriterTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/JsonStreamer/Tests/Fixtures/Model/DummyWithNestedDummies.php
Outdated
Show resolved
Hide resolved
01a7ad6 to
9b2b944
Compare
mtarld
approved these changes
Dec 2, 2025
Contributor
mtarld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @DjordyKoert 🙂
stof
approved these changes
Dec 2, 2025
Member
|
Thank you @DjordyKoert. |
9b2b944 to
5e371e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
symfony/json-streamercomponent on an object which contains a list of self (list<int, self>,self[]) generates invalid JSON.This happens because the generated code does not yield a comma (
,) for the first entry in the list and instead outputs an additional comma at the end of the list.A class like:
Currently outputs invalid JSON:
{"dummies":[{"dummies":[]}{"dummies":[]},{"dummies":[]},]}This PR fixes the above example to output valid JSON:
{"dummies":[{"dummies":[]},{"dummies":[]},{"dummies":[]}]}