Skip to content

[Serializer] Correct deserialization of scalars in arrays #62352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SamuilovAD wants to merge 1 commit into
base: 8.1
Choose a base branch
from
Open

[Serializer] Correct deserialization of scalars in arrays #62352

SamuilovAD wants to merge 1 commit into from
+565 −0

Conversation

@SamuilovAD
Copy link
Contributor

@SamuilovAD SamuilovAD commented Nov 9, 2025 •
edited
Loading

Q A
Branch? 8.1
Bug fix? no
New feature? yes
Deprecations? no
Issues #53490
License MIT

@SamuilovAD SamuilovAD requested a review from dunglas as a code owner November 9, 2025 17:49
@carsonbot carsonbot added this to the 7.4 milestone Nov 9, 2025
@carsonbot
Copy link

carsonbot commented Nov 9, 2025

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.4 for features / 6.4, 7.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title WIP: [Serializer] Correct deserialization of scallars in arrays [Serializer] WIP: Correct deserialization of scallars in arrays Nov 9, 2025
@SamuilovAD
Copy link
Contributor Author

SamuilovAD commented Nov 9, 2025

@nicolas-grekas
WIP. Pls review

@SamuilovAD SamuilovAD marked this pull request as draft November 9, 2025 17:57
@OskarStark OskarStark changed the title [Serializer] WIP: Correct deserialization of scallars in arrays [Serializer] Correct deserialization of scalars in arrays Nov 10, 2025
@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 3 times, most recently from 178aeff to b3218d7 Compare November 10, 2025 20:11
@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 4 times, most recently from 4fb85f5 to c99decb Compare November 11, 2025 17:55
@SamuilovAD SamuilovAD marked this pull request as ready for review November 11, 2025 17:59
@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 2 times, most recently from 1f170ee to 6e26a74 Compare November 11, 2025 18:13
@SamuilovAD SamuilovAD marked this pull request as draft November 11, 2025 18:13
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 12, 2025

Could #58473 help instead?

@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 2 times, most recently from e7a170f to aaeb041 Compare November 12, 2025 17:49
@SamuilovAD
Copy link
Contributor Author

SamuilovAD commented Nov 12, 2025

Could #58473 help instead?

No, It doesn't work with values inside arrays.

@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 8.1 Nov 16, 2025
@SamuilovAD SamuilovAD marked this pull request as ready for review November 17, 2025 16:53
@SamuilovAD SamuilovAD changed the base branch from 8.1 to 8.0 November 18, 2025 17:40
@SamuilovAD SamuilovAD changed the base branch from 8.0 to 8.1 November 18, 2025 17:43
@SamuilovAD SamuilovAD changed the base branch from 8.1 to 8.0 November 18, 2025 17:44
@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 6 times, most recently from c5a2454 to 6df0ba7 Compare November 25, 2025 16:23
@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 2 times, most recently from 83fbbda to fc3a19b Compare December 1, 2025 15:00
@SamuilovAD
Copy link
Contributor Author

SamuilovAD commented Dec 1, 2025

@nicolas-grekas, could you please assist me? I am waiting for resolving lowest-php check and it always fails several weeks. What could I do from my side?

@SamuilovAD SamuilovAD requested a review from chalasr as a code owner December 2, 2025 19:09
@SamuilovAD SamuilovAD changed the base branch from 8.0 to 8.1 December 2, 2025 19:10
@SamuilovAD SamuilovAD force-pushed the feature/ISSUE-53490 branch 3 times, most recently from 37f749a to dc4b862 Compare December 5, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@chalasr chalasr Awaiting requested review from chalasr

1 more reviewer

@Asisyas Asisyas Asisyas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Serializer Status: Needs Review

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@SamuilovAD @carsonbot @nicolas-grekas @Asisyas