[DependencyInjection] Parse attributes found on abstract classes for resource definitions #61578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83dcc2a to
2ea2afc
Compare
b253363 to
ad44cf6
Compare
nicolas-grekas
commented
Sep 2, 2025
| { | ||
| return $this->addTag($name, $attributes) | ||
| ->addTag('container.excluded', ['source' => \sprintf('by tag "%s"', $name)]) | ||
| ->setAbstract(true); |
Member
Author
There was a problem hiding this comment.
When a resource tag is set using ContainerBuilder::registerAttributeForAutoconfiguration(), this "abstract" flag isn't set on corresponding services. The reason is that autoconfiguration cannot set this flag by design - it's ignored in ResolveInstanceofConditionalsPass (and used for something else - aka cannot be reclaimed).
This means resource definitions are most of the time NOT going to be defined as abstract.
Therefor, this call here is useless, and confusing.
0b6e38a to
a4c825f
Compare
…resource definitions
a4c825f to
6571f7b
Compare
stof
approved these changes
Sep 2, 2025
fabpot
approved these changes
Sep 2, 2025
Member
|
Thank you @nicolas-grekas. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves support for resource definitions by allowing to parse attributes on abstract classes.
This can be useful for PRs like #61563 and #61545, so that the attribute proposed there could be set on abstract classes.