[SecurityBundle] Add missing fixXmlConfig() calls
#60996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
223af63 to
a887d78
Compare
Member
|
Isn't this relevant for older Symfony releases as well? |
Contributor
Author
|
I would say yes for the issuer and one of the algorithms |
stof
requested changes
Jul 2, 2025
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
a887d78 to
256bee4
Compare
OskarStark
commented
Jul 2, 2025
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Show resolved
Hide resolved
fabpot
requested changes
Aug 17, 2025
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
…ler arrays Add fixXmlConfig() calls for 'issuers' and 'algorithms' arrays to allow using singular XML tags that get automatically converted to plural form. This improves XML configuration ergonomics. As requested in PR symfony#60929
…/AccessToken/OidcTokenHandlerFactory.php
abad2b0 to
d9f1aad
Compare
Member
|
It seems like the calls are still in the wrong place. |
Contributor
Author
|
Yes they are, will try to find time soon |
The fixXmlConfig() calls should be placed at the parent node level (oidc) rather than on individual child array nodes (issuers, algorithms) to properly handle XML configuration transformations.
fixXmlConfig() calls for OIDC token handler arraysfixXmlConfig() calls
fabpot
approved these changes
Aug 24, 2025
fabpot
reviewed
Aug 24, 2025
| ->arrayNode($this->getKey()) | ||
| ->fixXmlConfig($this->getKey()) | ||
| ->fixXmlConfig('issuer') | ||
| ->fixXmlConfig('algorithm') |
Member
There was a problem hiding this comment.
This one can only work in 8.0 as it already exists in 7.4 (not even sure that this is a good idea as the semantic is not going to be the same between the 2 versions).
Contributor
Author
There was a problem hiding this comment.
fabpot
reviewed
Aug 24, 2025
| $node | ||
| ->arrayNode($this->getKey()) | ||
| ->fixXmlConfig($this->getKey()) | ||
| ->fixXmlConfig('issuer') |
Contributor
Author
There was a problem hiding this comment.
fabpot
requested changes
Sep 9, 2025
Member
fabpot
left a comment
There was a problem hiding this comment.
@OskarStark Can you have a look at my comments and maybe split this PR depending on which version we target?
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
fixXmlConfig()calls for'issuers'and'algorithms'arrays to allow using singular XML tags that get automatically converted to plural form. This improves XML configuration ergonomics.