Skip to content

[Notifier] remove the Sms77 Notifier bridge #60852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

[Notifier] remove the Sms77 Notifier bridge #60852

merged 1 commit into from
Jun 21, 2025

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 20, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from OskarStark as a code owner June 20, 2025 13:01
@carsonbot carsonbot added this to the 8.0 milestone Jun 20, 2025
nicolas-grekas
nicolas-grekas reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should abandon the package also?
I'll let you @fabpot merge this PR is you don't mind, also for the subtree split.
@xabbuh can you please rebase? I'm wondering if this might break on FWB 7.4? (where the Sms77 call will be missing on high-deps)

@fabpot
Copy link
Member

fabpot commented Jun 21, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 6d05df6 into symfony:8.0 Jun 21, 2025
10 of 13 checks passed
@fabpot fabpot mentioned this pull request Jun 21, 2025
Closed
@xabbuh xabbuh deleted the pr-58200 branch June 21, 2025 11:53
@xabbuh
Copy link
Member Author

xabbuh commented Jun 21, 2025

@fabpot @nicolas-grekas I guess in addition to marking the package as abandoned on Packagist we also have to remove the 8.0 branch from the subtree-split repository.

@fabpot
Copy link
Member

fabpot commented Jun 29, 2025

@fabpot @nicolas-grekas I guess in addition to marking the package as abandoned on Packagist we also have to remove the 8.0 branch from the subtree-split repository.

Done

@fabpot fabpot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

Feature Notifier Status: Reviewed

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh @fabpot @nicolas-grekas @OskarStark @carsonbot