Update onTaxCodeSelect prop on the PTC selector #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
approved these changes
Aug 27, 2025
Contributor
jorgea-stripe
left a comment
There was a problem hiding this comment.
LGTM, but can you make sure we run LINT?
| initialTaxCode | ||
| }: { | ||
| onTaxCodeSelect?: (taxCode: string) => void; | ||
| onTaxCodeSelect?: (taxCode: string, { analyticsName }: { analyticsName: string }) => void; |
Contributor
There was a problem hiding this comment.
Does this need LINT?
Contributor
There was a problem hiding this comment.
Can you make sure to run locally before merge?
Contributor
Author
There was a problem hiding this comment.
Certainly! I've run yarn run lint locally to verify there's no change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the type definition for the
onTaxCodeSelectprop, based on the approved API Review addendum.