Skip to content

Conversation

@joseluisq
Copy link
Collaborator

Description

This PR prevents duplicate Vary headers in responses when enabling compression and compression-static.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

it prevents duplicate `vary` headers in responses when enabling
`compression` and `compression-static`.
@joseluisq joseluisq added v2 v2 release bugfix This is PR fixes a bug labels Jun 6, 2024
@semanticdiff-com
Copy link

semanticdiff-com bot commented Jun 6, 2024

Review changes with SemanticDiff.

Analyzed 10 of 10 files.

Overall, the semantic diff is 25% smaller than the GitHub diff.

Filename Status
✔️ src/compression.rs Analyzed
✔️ src/compression_static.rs Analyzed
✔️ src/handler.rs 44.31% smaller
✔️ src/testing.rs 9.91% smaller
✔️ tests/compression.rs Analyzed
✔️ tests/compression_static.rs Analyzed
✔️ tests/experimental_metrics.rs 74.98% smaller
✔️ tests/handler.rs 27.72% smaller
✔️ tests/redirects.rs 47.52% smaller
✔️ tests/rewrites.rs 47.88% smaller

@joseluisq joseluisq added this to the v2.32.0 milestone Jun 6, 2024
@joseluisq joseluisq merged commit 3410365 into master Jun 6, 2024
@joseluisq joseluisq deleted the fix-duplicated-vary-headers-cmpression branch June 6, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This is PR fixes a bug v2 v2 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants