update installer.sh to support overriding default variables #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
joseluisq
requested changes
May 22, 2024
Collaborator
joseluisq
left a comment
There was a problem hiding this comment.
Nice idea. I wonder if you could also update the installer page with an example of how to use it. https://github.com/static-web-server/static-web-server/blob/master/docs/content/download-and-install.tmpl.md#binary-installer-linuxbsds
BTW can you please also update the PR with the example?
Collaborator
|
BTW since it is a script (dynamic) and already merged. It should be already available to be used. The docs should be published soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds two optional environment variables controlling the installation script:
Motivation and Context
when installing with get.static-web-server.net, I would like to be able to pin the install version and specify an installation directory (so I can use it in packaging scripts)