Skip to content

feat(statement): server side prepared statement #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 5, 2024
Merged

feat(statement): server side prepared statement #141

merged 7 commits into from
Dec 5, 2024

Conversation

@danielebriggi
Copy link
Member

@danielebriggi danielebriggi commented Nov 20, 2024 •
edited
Loading

Issue: #122

  • command is serialized as array to be processed as prepared statement

Depends on #153

@danielebriggi danielebriggi self-assigned this Nov 20, 2024
@danielebriggi danielebriggi added enhancement New feature or request and removed enhancement New feature or request labels Nov 20, 2024
@danielebriggi danielebriggi force-pushed the #122-implement-server-side-prepared-statement branch from 054495d to 3181844 Compare November 21, 2024 09:22
@danielebriggi
Copy link
Member Author

danielebriggi commented Nov 21, 2024

as correctly pointed out by Gioele, also connection-ws.ts should have some changes. I have to update the gateway to use this version of the driver (which on depends this connection class) and then you can approve both the PRs.

@danielebriggi danielebriggi force-pushed the #122-implement-server-side-prepared-statement branch 4 times, most recently from 0d4a59d to fb50238 Compare November 27, 2024 15:14
@danielebriggi danielebriggi force-pushed the #122-implement-server-side-prepared-statement branch from fb50238 to b029a0f Compare November 29, 2024 13:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2024
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.16667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (5bdba10) to head (75e489a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/connection.ts 78.57% 3 Missing ⚠️
src/drivers/database.ts 86.95% 3 Missing ⚠️
src/drivers/protocol.ts 91.17% 3 Missing ⚠️
src/drivers/statement.ts 91.17% 3 Missing ⚠️
src/drivers/utilities.ts 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   87.42%   87.34%   -0.08%     
==========================================
  Files          11       11              
  Lines         978      972       -6     
  Branches      310      286      -24     
==========================================
- Hits          855      849       -6     
  Misses        123      123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielebriggi danielebriggi force-pushed the #122-implement-server-side-prepared-statement branch from 4a950fb to b0c5457 Compare November 29, 2024 14:23
@danielebriggi danielebriggi force-pushed the #122-implement-server-side-prepared-statement branch from e4bc40a to a9952b7 Compare December 4, 2024 10:07
@danielebriggi danielebriggi merged commit 910b6c8 into main Dec 5, 2024
22 checks passed
@danielebriggi danielebriggi deleted the #122-implement-server-side-prepared-statement branch December 5, 2024 13:37
@danielebriggi danielebriggi restored the #122-implement-server-side-prepared-statement branch December 5, 2024 13:41
@danielebriggi danielebriggi deleted the #122-implement-server-side-prepared-statement branch December 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gioee Gioee Gioee approved these changes

@TizianoT TizianoT Awaiting requested review from TizianoT

Assignees

@danielebriggi danielebriggi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danielebriggi @codecov-commenter @Gioee