Skip to content

Fix the runtime issue related to the join operation in the associatio… #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix the runtime issue related to the join operation in the associatio… #11721

merged 1 commit into from
Sep 4, 2024

Conversation

@LongQIByte
Copy link
Contributor

@LongQIByte LongQIByte commented Aug 11, 2024 •
edited
Loading 

q = session.query(Order).join("order_items", "item")

modify to:

q = session.query(Order).join(OrderItem).join(Item)

Description

Fixes: #11720

Checklist

This pull request is:

  • A documentation / typographical / small typing error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@CaselIT
Copy link
Member

CaselIT commented Aug 11, 2024 •
edited
Loading

Hi,

This is already updated in thia other pr that's a general improvement of many examples #11437

@zzzeek do you prefer merging this small one first?

@zzzeek
Copy link
Member

zzzeek commented Aug 11, 2024

Hi,

This is already updated in thia other pr that's a general improvement of many examples #11437

@zzzeek do you prefer merging this small one first?

#11437 just goes too far to review all at once with things I dont even know what they are (what's a "fabfile"?) so it's unmergeable, I really wish it could be broken up into small changes

given that sentiment lets merge this one and backport to 2.0

@CaselIT CaselIT merged commit e8dfefb into sqlalchemy:main Sep 4, 2024
sqlalchemy-bot pushed a commit that referenced this pull request Sep 4, 2024
@LongQIByte @CaselIT
Fix the runtime issue related to the join operation in the associatio…
a538996 
…n example (#11721)

(cherry picked from commit e8dfefb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The runtime issue related to the join operation in the association example

3 participants

@LongQIByte @CaselIT @zzzeek