Skip to content

enable json1 extension #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lovasoa merged 1 commit into from
Mar 15, 2021
Merged

enable json1 extension #440

lovasoa merged 1 commit into from
Mar 15, 2021

Conversation

@kaizhu256
Copy link
Member

@kaizhu256 kaizhu256 commented Mar 3, 2021

motivation

  • fixes JSON1? #259 (json is used an awful lot in javascript ;)
  • maintain feature-parity with node-sqlite3, which includes json1 by default

impact on file-size

comparing build-artifacts between this pr and master,
there's a 2.68% increase in filesize for sql-wasm.wasm:

file                          master    pr.json1  size_increase
----                          --------  --------  ----------------
worker.sql-asm-debug.js       10868144  11054003  +185859 (1.71 %)
sql-asm-debug.js              10865661  11051520  +185859 (1.71 %)
sql-asm-memory-growth.js       2387025   2453699   +66674 (2.79 %)
worker.sql-asm.js              2386050   2452724   +66674 (2.79 %)
sql-asm.js                     2383567   2450241   +66674 (2.80 %)
sql-wasm-debug.wasm            1223845   1256667   +32822 (2.68 %)
sql-wasm.wasm                  1137969   1168425   +30456 (2.68 %)
worker.sql-wasm-debug.js        284549    284549        0
sql-wasm-debug.js               282066    282066        0
worker.sql-wasm.js               56224     56224        0
sql-wasm.js                      53741     53741        0

@lovasoa lovasoa merged commit 8a73921 into sql-js:master Mar 15, 2021
@lovasoa
Copy link
Member

lovasoa commented Mar 15, 2021

Thank you @kaizhu256 !

@kaizhu256
Copy link
Member Author

kaizhu256 commented Mar 15, 2021

woot!

@saaj saaj mentioned this pull request May 1, 2021
Open
@damion-add-on-depot
Copy link

damion-add-on-depot commented Aug 28, 2021

Is there a list of all supported extensions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSON1?

3 participants

@kaizhu256 @lovasoa @damion-add-on-depot