Skip to content

Use torch.log1p and torch.special.expm1 #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TParcollet merged 1 commit into from
Jan 14, 2025
Merged

Use torch.log1p and torch.special.expm1 #2797

TParcollet merged 1 commit into from
Jan 14, 2025

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Jan 11, 2025

What does this PR do?

Use torch.log1p and torch.special.expm1.
These functions provide better precision for small values of the argument.

Found with TorchFix https://github.com/pytorch-labs/torchfix/

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@kit1980
Use torch.log1p and torch.special.expm1
66202a3 
This functions provide better precision for small values of the argument.

Found with TorchFix https://github.com/pytorch-labs/torchfix/
pplantinga
pplantinga approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TParcollet TParcollet merged commit 26e3440 into speechbrain:develop Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pplantinga pplantinga pplantinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kit1980 @pplantinga @TParcollet