Skip to content

Fixes #2656: Remove EOS from SoundChoice #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asumagic merged 1 commit into from
Oct 18, 2024
Merged

Fixes #2656: Remove EOS from SoundChoice #2718

asumagic merged 1 commit into from
Oct 18, 2024

Conversation

@flexthink
Copy link
Collaborator

@flexthink flexthink commented Oct 11, 2024 •
edited
Loading

What does this PR do?

Removes EOS from SoundChoice G2P
Fixes #2656

Breaking change: GraphemeToPhoneme will no longer output the token - any code relying on it will break.

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@flexthink flexthink marked this pull request as ready for review October 11, 2024 20:56
@flexthink flexthink requested a review from mravanelli October 11, 2024 20:56
@TParcollet
Copy link
Collaborator

TParcollet commented Oct 14, 2024

@mravanelli can you have a look please?

@asumagic asumagic merged commit 2d157c4 into speechbrain:develop Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asumagic asumagic asumagic approved these changes

@mravanelli mravanelli Awaiting requested review from mravanelli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

soundchoice-g2p on HF emits <eos> symbol (which HF tests don't expect)

3 participants

@flexthink @TParcollet @asumagic