fixed broken augmentation integration tests #2628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The integration tests for the data augmentation portion of the code base are broken. I assume at some point code was changed and due to pure coincidence, and the way the tests were written, they still pass. The main function in all the tests is never called, which means results are never generated. Since there are no results in the results directory, the tests run
for filename in glob(os.path.join(output_folder, "save", "*.flac"))however this folder will be empty, meaning the tests will all pass because the test function will return after having done nothing.This PR fixes and improves these tests. I intend to add the integration tests for the other augmentations not currently covered in another PR.
Main Changes
time_domain/freq_domaininstead ofspeech_augmentAddNoiseaugmentation which is already coveredpython example_.pyinstead of main functionFixes #<issue_number>
Before submitting
PR review
Reviewer checklist