Rewrite multi-GPU documentation #1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ugh, pre-commit checks fail to intended trailing whitespaces in the markdown. I'll remove them for now. |
This made the pre-commit hooks fail, even though double trailing spaces were intended for line returns without starting a new paragraph.
Adel-Moumen
reviewed
Feb 24, 2023
Adel-Moumen
reviewed
Feb 24, 2023
Collaborator
|
Thanks @asumagic! |
Collaborator
Author
|
I made the suggested changes and added details on what the parameters to |
Adel-Moumen
approved these changes
Feb 24, 2023
Collaborator
Adel-Moumen
left a comment
There was a problem hiding this comment.
LGTM! I really like your changes. I think it will help a lot of ppl! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1860. The changes to the document are quite in-depth and there is new added info, so this PR needs to be fact-checked aside of proofreading.
The resulting compiled document looks as intended.
Overview of the changes
Additional notes
The Colab tutorial (which was brought up in the issue here) is not linked in the document as of this PR. It should probably be updated to the contents of this PR, but as unless it actually gets any different content from the documentation, it probably doesn't need to be linked from the docs.
@anautsch (in DMs) mentioned DDP tests and some changes from #1817 that indirectly affect DDP. This PR mentions neither at the time, but perhaps someone more qualified than me could enhance the DDP-safety subsection further.