feat: use member field instead of hard-code #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Adel-Moumen Hi this PR aims to address issue #1451 |
anautsch
reviewed
Sep 12, 2022
Collaborator
anautsch
left a comment
There was a problem hiding this comment.
@Adel-Moumen lgtm
The proposed change relates to lines 321-323, where self.positive_label is initialized - subsequently, it can also be used later on, as demonstrated in this PR.
def __init__(self, positive_label=1):
self.clear()
self.positive_label = positive_label
anautsch
approved these changes
Sep 12, 2022
Collaborator
|
Lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1451 It's better to use member filed
self.positive_labelthan hard code to 1.