wav2vec German model added #1557

sangeet2020 · 2022-08-30T01:15:35Z

I initiate a pull request with the following additions, modifications and fixings:

[Addition] A new wav2vec model has been fine-tuned on the CommonVoice German dataset. For this I add a new hyper-param yaml file. README has been updated accordingly. Discussed with @mravanelli and to be later put into huggingface/speechbrain.
[Fixings] In the file speechbrain/processing/features.py, a bug has been fixed as proposed in Device error when setting deltas=True in speechbrain.lobes.features.Fbank. #1489
[Non-important Modification] Progress bar has been color-coded (gree, magenta, cyan)

Thank You

Adel-Moumen

Huge thanks for the PR!! Always great to have new languages in SpeechBrain 😁

Could you please update the README and add German too? (maybe you can add there the time taken per epoch)

If you agree, I will create a new model card on hugging face with this model when everything is ready. Then, you will have to make a pull request to add your model etc... 🤗

About what you did for the colouration in core.py, we will need more discussion on it. Could you please undo the core change with colour and create a separate pull request on that?

Your code failed on some tests (pre-commit and test), please run the pre-commit and tests as described here 🙂

Make sure to add your recipe in tests/recipes.csv to fix the test issue

Last but not least, could you please make sure that your .yaml is in the same order as the other .yaml (e.g French, Italian...)? For instance, you defined on line 104 the wav2vec2_hub while in the other yaml it is done on line 17. Could you please make sure that everything is similar?

recipes/CommonVoice/ASR/CTC/README.md

recipes/CommonVoice/ASR/CTC/hparams/train_de_with_wav2vec.yaml

recipes/CommonVoice/common_voice_prepare.py

sangeet2020 · 2022-09-08T21:01:10Z

Readme has been updated
Coloration in core.py has been reverted.
German hyper-params .yaml file has been fixed as per suggestions.
Pre-commit and tests - sucessful

sangeet2020 · 2022-09-11T00:05:26Z

@Adel-Moumen Changes are ready to be reviewed.
Thanks

Adel-Moumen

Hello,

Thanks for the changes!

There are some minor edits that I would like you to make, please. I will also create your HuggingFace card for this model asap, you will then need to update the link for the model as well.

Many thanks for your excellent work!

recipes/CommonVoice/ASR/CTC/hparams/train_de_with_wav2vec.yaml

recipes/CommonVoice/ASR/CTC/README.md

tests/recipes.csv

sangeet2020 · 2022-09-22T23:10:44Z

Apologies @Moumeneb1 , I had to close this PR, and re-open it because it got messed up when I pulled the latest changes today.
Thank You

Adel-Moumen · 2022-09-26T18:25:00Z

Apologies @Moumeneb1 , I had to close this PR, and re-open it because it got messed up when I pulled the latest changes today. Thank You

Hello, you pinged the wrong reviewer Ahah.

There is one last thing that needs to be done is the upload of your model on the HuggingFace hub. For now, we will need to wait a little bit more. Unfortunately, the process takes a little bit of time.

sangeet2020 · 2022-09-26T19:04:29Z

Sure thing.

sangeet2020 · 2022-10-18T01:00:59Z

@Adel-Moumen I was wondering if we have any updates further? ~Thanks

Adel-Moumen · 2022-10-21T16:21:29Z

Hello,

It will be ready next week! :)

Adel-Moumen · 2022-10-25T08:57:38Z

Hello @sangeet2020,

Could you please resolve the conflict with the test/recipes.csv? Afterwards, we will merge this PR.

I did not finish the upload on the HF model hub. I struggled to host your model on the hub due to the tokenizer used.

If you agree, I can add you to the HF SpeechBrain organisation and then you will have to create a PR on the model card to add everything necessary.

Let me know what you think! Thanks. :-)

mravanelli · 2022-11-02T16:10:20Z

@sangeet2020, could you please solve the conflit? Also, it could be great if @anautsch could give a final look before merging it

…into develop

sangeet2020 · 2022-11-02T21:20:47Z

Re-opening the PR, fixing conflicts with test/recipes.csv

sangeet2020 · 2022-11-02T21:29:18Z

Now, I can host the new German CommonVoice model on HF. You can add me to the SpeechBrain organization.
Here is my username: sangeet2020

And apologies for the delay, bit busy with a new recipe for Microsoft DNS. Should be on SpeechBrain soon. :)

Adel-Moumen · 2022-11-03T16:33:39Z

Hello,

I added you to the HF organization. You can create a private repository on the organization, and start working on it! Let me know if you need more help. (you can reach me directly on slack)

Please fix the recipes :)

sangeet2020 · 2022-11-04T04:27:06Z

@Adel-Moumen

Model uploaded in HF as a pvt repo.
recipes.csv fixed
Other details sent on slack.

Thank You

Adel-Moumen

Hello,

Thanks a lot! I tried your model and it's working perfectly.

Could you please update the readme, and recipe.csv with the model link, then we will merge the PR! :)

recipes/CommonVoice/ASR/CTC/README.md

tests/recipes.csv

Adel-Moumen

everything looks great! thanks!

sangeet2020 · 2022-11-04T15:57:49Z

Thank you very much!!
SpeechBrain team

TParcollet · 2022-11-04T23:22:04Z

Thanks for contributing.

sangeet2020 · 2022-11-06T17:15:13Z

@Adel-Moumen please check the model in the SpeechBrain's google drive link. You uploaded the model dir named CKPT+2022-08-16+00-27-35+00 and this happens to be checkpoint for epoch 31 (you can check this from log.txt file). Could you please please upload the checkpoint for epoch 45 from here (GDrive LINK) The checkpoint folder for epoch 45 is CKPT+2022-08-19+23-10-33+00
Please let me know if there is any confusion

Thank You

Adel-Moumen · 2022-11-06T17:51:47Z

Hi, please accept me on the gdrive thanks.

sangeet2020 · 2022-11-06T17:53:43Z

Hi, please accept me on the gdrive thanks.

Editing access granted.

Adel-Moumen · 2022-11-06T18:02:26Z

Thanks.

I will edit the folder tomorrow!

Adel-Moumen · 2022-11-07T07:34:54Z

Hello @sangeet2020,

Is it better like that? :-)

sangeet2020 · 2022-11-07T10:39:02Z

Yes, this looks alright now :). Thank you very much.

Adel-Moumen self-assigned this Sep 5, 2022

Adel-Moumen requested changes Sep 6, 2022

View reviewed changes

sangeet2020 closed this Sep 10, 2022

sangeet2020 reopened this Sep 10, 2022

sangeet2020 force-pushed the develop branch from c0f7b66 to 80fb945 Compare September 10, 2022 18:02

sangeet2020 requested a review from Adel-Moumen September 12, 2022 02:02

Adel-Moumen requested changes Sep 17, 2022

View reviewed changes

recipes/CommonVoice/ASR/CTC/hparams/train_de_with_wav2vec.yaml Outdated Show resolved Hide resolved

recipes/CommonVoice/ASR/CTC/README.md Outdated Show resolved Hide resolved

tests/recipes.csv Outdated Show resolved Hide resolved

sangeet2020 closed this Sep 22, 2022

sangeet2020 force-pushed the develop branch from 4d9c7b2 to 51f60fc Compare September 22, 2022 16:54

re-commiting changes and fixes

2553923

sangeet2020 reopened this Sep 22, 2022

sangeet2020 closed this Nov 2, 2022

sangeet2020 force-pushed the develop branch from 2553923 to 64c8fa9 Compare November 2, 2022 20:56

sangeet2020 added 2 commits November 2, 2022 22:03

Merge branch 'develop' of https://github.com/sangeet2020/speechbrain …

0fe1e3a

…into develop

updating recipe ID for German CommonVoice

86e1ad3

sangeet2020 reopened this Nov 2, 2022

Updating recipes.csv with most recent recipes

9ffe2e2

updating recipe ID for GermanCV

786a12a

fixing per-merge conflicts

9a84039

Adel-Moumen requested changes Nov 4, 2022

View reviewed changes

recipes/CommonVoice/ASR/CTC/README.md Outdated Show resolved Hide resolved

tests/recipes.csv Outdated Show resolved Hide resolved

HF model link added

0169c73

Adel-Moumen approved these changes Nov 4, 2022

View reviewed changes

Adel-Moumen merged commit 11c70de into speechbrain:develop Nov 4, 2022

wav2vec German model added #1557

wav2vec German model added #1557

Uh oh!

Conversation

sangeet2020 commented Aug 30, 2022

Uh oh!

Adel-Moumen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sangeet2020 commented Sep 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sangeet2020 commented Sep 11, 2022

Uh oh!

Adel-Moumen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sangeet2020 commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Adel-Moumen commented Sep 26, 2022

Uh oh!

sangeet2020 commented Sep 26, 2022

Uh oh!

sangeet2020 commented Oct 18, 2022

Uh oh!

Adel-Moumen commented Oct 21, 2022

Uh oh!

Adel-Moumen commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mravanelli commented Nov 2, 2022

Uh oh!

sangeet2020 commented Nov 2, 2022

Uh oh!

sangeet2020 commented Nov 2, 2022

Uh oh!

Adel-Moumen commented Nov 3, 2022

Uh oh!

sangeet2020 commented Nov 4, 2022

Uh oh!

Adel-Moumen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Adel-Moumen left a comment

Choose a reason for hiding this comment

Uh oh!

sangeet2020 commented Nov 4, 2022

Uh oh!

TParcollet commented Nov 4, 2022

Uh oh!

sangeet2020 commented Nov 6, 2022

Uh oh!

Adel-Moumen commented Nov 6, 2022

Uh oh!

sangeet2020 commented Nov 6, 2022

Uh oh!

Adel-Moumen commented Nov 6, 2022

Uh oh!

Adel-Moumen commented Nov 7, 2022

Uh oh!

sangeet2020 commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Adel-Moumen left a comment •

edited

Loading

sangeet2020 commented Sep 8, 2022 •

edited

Loading

sangeet2020 commented Sep 22, 2022 •

edited

Loading

Adel-Moumen commented Oct 25, 2022 •

edited

Loading