fix 1522 #1526
Merged
fix 1522 #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@mravanelli please take a look. If you want, I can put the profiling tests in one test function (right now, each test function call takes the same amount of time of some 0.5s which could indicate fixed setting up/tearing down costs are repeated - otherwise, the tests demonstrate profiling is more expensive as a whole activity than just running scripts; which should be the case, too). |
mravanelli
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1522
Imports in
core.utils.profiling.pywere too depending on a particular pytorch version (were dropped later). This caused errors or downgrades on user site. Depending tests were commented out as well.