Add revision to hub download #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @TParcollet! LGTM though I must confess I like the |
pplantinga
approved these changes
Jul 21, 2022
Collaborator
pplantinga
left a comment
There was a problem hiding this comment.
I tried this and everything seems to work! I was wondering if there were other instances of fetch() that ought to be updated, and came across speechbrain.pretrained.interfaces.foreign_class which doesn't seem to be referenced anywhere? And I also looked at the speechbrain.utils.parameter_transfer which doesn't seem straightforward to modify.
All this to say, LGTM.
Collaborator
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature requested in #1509. We now can request a specific revision when using our interfaces.
@hbredin for some reasons, I can't add you as a reviewer so I asked someone from the team to do it. Please feel free to try the PR and let us know if it works well for you!