Remove torch maximum compatible version #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TParcollet
reviewed
Jul 18, 2022
| "packaging", | ||
| "scipy", | ||
| "sentencepiece", | ||
| "torch>=1.7,<=1.11", |
Collaborator
There was a problem hiding this comment.
Wouldn't this cause an error ? 1. nothing after
Collaborator
Author
There was a problem hiding this comment.
The 7 is replaced by a 9 to try and synchronize the requirements.txt and setup.py to have the same minimum version of torch. I'm not totally sure why it was different to begin with, if you know it was intentional we can leave it as 1.7
TParcollet
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1493
As PyTorch is more stable, I think it makes sense to remove the maximum compatible version.
Is anyone aware of why the minimum versions were different between
setup.pyandrequirements.txt? I updatedsetup.pyto reflect the more stringent requirement inrequirements.txtbut anyone with more info could chime in if there is a good reason for it.