Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the file
distributed.py, some errors can be raised suggesting the use of--distributed_launch=Truewhich is misleading because it is not what the user is supposed to do. According to the official documentation of SpeechBrain, if one wants to use DDP then he needs to use--distributed_launchinstead of--distributed_launch=True-> https://speechbrain.readthedocs.io/en/v0.5.8/multigpu.htmlMoreover,
--distributed_launch=Truewill not work. I tried to do a little example on my GPUs cluster where I'm training an LSTM on the CommonVoice French recipe of SpeechBrain using 2x v100s:with
--distributed_launch=TrueI got an error: torch.distributed.elastic.multiprocessing.errors.ChildFailedError ......whearas
--distributed_launchdo everything that is expected, i.e train the LSTM.I got the same return from a colleague who tried to use DDP and was stuck due to the errors thrown that were suggesting to set to
True.P.S.: I also need to change every comment in the recipes that suggests that. E.g. CommonVoice ASR seq2seq in
train.py-># If distributed_launch=Truebut I'm waiting for an official reviewer to confirm the problem.Best,