fix: collect results after last error in ResultErrorPool#162
Open
Yanhu007 wants to merge 1 commit intosourcegraph:mainfrom
Open
fix: collect results after last error in ResultErrorPool#162Yanhu007 wants to merge 1 commit intosourcegraph:mainfrom
Yanhu007 wants to merge 1 commit intosourcegraph:mainfrom
Conversation
The collect method in resultAggregator skipped all results that came after the last errored task. The filtering loop only appended segments between errored indices but never appended the tail segment after the last error. For example, with tasks [ok, err, ok], only the first ok was returned instead of both ok results. Add the tail segment after the loop. Add regression test. Fixes sourcegraph#156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156
Problem
ResultErrorPool.Wait()drops all results that come after the last errored task:The
collectmethod's filtering loop appends segments between errored indices but never appends the tail segment after the last error.Fix
Append the tail segment (
results[lastErrored+1:]) after the loop.Regression test added.
All existing tests pass.