-
Notifications
You must be signed in to change notification settings - Fork 537
WIP add functions for creating chamfers and fillets to the NURBS kernel #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ting chamfers and fillets. The function is hooked in Group::Generate but does not modify the shell at this point so it is benign.
|
@phkahler great to see you attempting this. Over the years I've been considering this - most recently at the time Dune3D started. In my head it works similarly to what you started outlining with one more level of abstraction: A chamfer/fillet is:
In the future the patch class can be used to implement generic patch functionality - e.g. close a "random" hole outlined by a contour of any edges (not necessarily straight) in 3d. A general purpose patch tool may/will have to generate new edges on it's own (imagine a corner where a few edges meet and they are all filleted) and I am not sure how this will be handled by this approach. Intersections of the newly created NURBS surfaces will be these new edges. |
Woops you're right. Curves are not duplicated, but there are two TrimBy, one for each surface that meets along a curve. These reference the same underlying curve but one is "backward". So I'll still need to generate 2 new curves, and move both Trims rather than creating a new one. Good news - the PWL points are not in the trims! Assuming all fillets meeting at a point are the same radius, the surface we want there is spherical. It's really hard to find anything (with google) on spherical NURBS patches, never mind triangular ones. But that's for later. Chamfers first and Fillets with 1 or 2 per vertex. I'm both excited and dreading this... |
Indeed :-) |
|
I very welcome the attempt to add this. :) |
…le at the origin and extruded.
|
Getting back to this soon. Here is a sketch to visualize how fillets meet at a corner. Drag the green lines around. For equal radius fillets it forms a spherical triangle. |
Just an outline at this point (in the code). Hoping to attempt this over the hollidays. Thought people might want to follow along or comment if this goes anywhere.