mac: Distinguish trackpad from Magic Mouse scroll #1274
Conversation
|
Just for cross-reference - the original issue is here #1106 |
|
I just compiled this and I still have the issue that when I scroll fast, in stead of panning SolveSpace zooms instead. Maybe we should not pan with 2 finger scroll, and use mouse-down-drag to pan (like it was in the past, I think?) |
This is the second attempt to distinguish trackpad scrolling that when used should yield panning from Magic Mouse scrolling that should control zoom. Since trackpad will begin with a touch prior to the scroll event, but Magic Mouse not, we can use it to make sure we trigger panning only on a trackpad. Previous "mac: Don't interpret single-touch scroll events as pan gestures" that was flawed was reverted which ultimately lead to being unable to zoom using Magic Mouse.
9cad14a to
0f4d966
Compare
|
@vespakoen Thanks for the report. I managed to reproduce and then fix the problem. Can you pull the latest update. TL;DR Actually we can have multiple touches when we accidentally touch trackpad with another finger when scrolling fast. Using counter instead of simple flag seems to resolve the problem to me and I am no longer able to trigger zoom with scrolling widely on my MBP with 2 fingers, while Magic Mouse on my Mini works great as well. |
|
This is working for me now as well. Thanks for working on this and figuring out a way to distinguish between mice ;) Merging... |
This is the second attempt to distinguish trackpad scrolling that when used should yield panning from Magic Mouse scrolling that should control zoom. Since trackpad will begin with a touch prior to the scroll event, but Magic Mouse not, we can use it to make sure we trigger panning only on a trackpad. Previous "mac: Don't interpret single-touch scroll events as pan gestures" that was flawed was reverted which ultimately lead to being unable to zoom using Magic Mouse.
This is the second attempt to distinguish trackpad scrolling that when used should yield panning from Magic Mouse scrolling that should control zoom. Since trackpad will begin with a touch prior to the scroll event, but Magic Mouse not, we can use it to make sure we trigger panning only on a trackpad. Previous "mac: Don't interpret single-touch scroll events as pan gestures" that was flawed was reverted which ultimately lead to being unable to zoom using Magic Mouse.
This is the second attempt to distinguish trackpad scrolling that when used
should yield panning from Magic Mouse scrolling that should control zoom.
Since trackpad will begin with a touch prior to the scroll event, but Magic
Mouse not, we can use it to make sure we trigger panning only on a trackpad.
Previous "mac: Don't interpret single-touch scroll events as pan gestures"
that was flawed was reverted which ultimately lead to being unable to zoom using
Magic Mouse.
This fixes again #1107 and is also related to #1218