Win32: Allow 32 bit SolveSpace to access up to 4GB of RAM. #1262
Conversation
cfd368e to
5e7a6b0
Compare
|
Looks ok (though it would be better to use target_compile_options on the targets directly) |
|
Looks good and is consistent with the rest of the cMake hodgepodge :)
For MinGW, it links with the equivalent to /LARGEADRESSAWARE, but not exactly with it. That'd be my only nitpick. |
Link 32 bit SolveSpace for Windows with /LARGEADDRESSAWARE which allows it to access up to 3GB of RAM on a properly configured 32 bit Windows and up to 4GB on 64 bit. See: https://msdn.microsoft.com/en-us/library/aa366778 https://docs.microsoft.com/en-us/cpp/build/reference/largeaddressaware-handle-large-addresses https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#characteristics https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc786709 https://docs.microsoft.com/en-us/windows/win32/memory/4-gigabyte-tuning Fixes: solvespace#1261
5e7a6b0 to
d864013
Compare
@rpavlik If I only knew what "target_compile_options" were in the context of cmake :-) Unfortunately I have no time to learn it.
@ppd Good catch - I fixed it and force pushed. |
|
I'm more concerned about what Solvespace models you're using that need that much memory 🤣 Thanks for the good work! |
|
BTW this doesn't actually "fix" the issue, it just pushes it out a bit further ;-) "Use 64bit Solvespace" is a nice workaround. |
Link 32 bit SolveSpace for Windows with /LARGEADDRESSAWARE which allows
it to access up to 3GB of RAM on a properly configured 32 bit Windows and
up to 4GB on 64 bit.
See: https://msdn.microsoft.com/en-us/library/aa366778
https://docs.microsoft.com/en-us/cpp/build/reference/largeaddressaware-handle-large-addresses
https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#characteristics
https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2003/cc786709
https://docs.microsoft.com/en-us/windows/win32/memory/4-gigabyte-tuning
Fixes: #1261