Use nullptr instead of NULL #1250
Conversation
|
@pap1rana thank you for the contribution. While Globally replacing I hope you are not discouraged by this. We always welcome new contributors and I would love to see future contributions from you. |
|
@ruevs I agree. OTOH we should probably make a list of big changes like that, and do them all in a row? For example, I opened #1210 which is just renaming. Another issue is that such changes may also cause existing WIP patches and branches to not automatically merge any more. OTOH there may never be a "good" time to do this. So no for now. |
|
I agree with you, this should be done as part of big changes list. |
|
You can ignore commits with Git Blame like here: https://akrabat.com/ignoring-revisions-with-git-blame/ It is only applied on a user by user basis though. |
|
Github now has support for the git blame ignore file. |
|
You can ignore changes like this with Git blame as described here: https://akrabat.com/ignoring-revisions-with-git-blame/
The bad part is that you need to apply on a user by user basis, but that could be documented.
|
I saw that you are developing with std=c++11, and using nullptr is recommended.
I excuted cmake
with extra flag for
-DCMAKE_EXPORT_COMPILE_COMMANDS=ONclang-tidy purpose.From build directory executed:
run-clang-tidy -checks='modernize-use-nullptr'After that i ran same command with -f to auto apply fixes:
After that i built everything again, ran app with no problems:
I even have executed
solvespace-testsuite: