fix: don't report sync as successful if best score is in negatives #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
LGTM, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easy to reproduce. Try using an input subtitle file that is not related to the video. Score is reported as negative while
sync_was_successfulis still reported as true.skip_syncis untouched. So ifskip_syncis true (which means best score would be 0),sync_was_successfulwill still report as true.PS: sorry for this being such a crude PR. I don't usually work in python and I couldn't come up with a test to add. I would happily take up the feedback to improve the PR if you give any.
@morpheus65535 please weigh in if you feel otherwise.