fix: add package.json to exports list #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change to logic. shx has a dependency on shelljs/package.json so that it can read the ShellJS version number. This is useful for shx and probably harmless for other packages (we need to ship the package.json file anyway), so this adds it to the exports list as an optional export. Fixes #1195 Test: I ran `shx --version` with this copy of shelljs as the dependency
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 35 35
Lines 1408 1408
=======================================
Hits 1371 1371
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nfischer
added a commit
to shelljs/shx
that referenced
this pull request
Mar 17, 2025
This is a small fix for the `--version` flag. This adds back ShellJS version number, which was re-exposed in PR shelljs/shelljs#1200. This reverts one of the workarounds added in PR #228. This also commits package-lock.json to the repo.
nfischer
added a commit
to shelljs/shx
that referenced
this pull request
Mar 17, 2025
This is a small fix for the `--version` flag. This adds back ShellJS version number, which was re-exposed in PR shelljs/shelljs#1200. This reverts one of the workarounds added in PR #228. This also commits package-lock.json to the repo.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to logic. shx has a dependency on shelljs/package.json so that it can read the ShellJS version number. This is useful for shx and probably harmless for other packages (we need to ship the package.json file anyway), so this adds it to the exports list as an optional export.
Fixes #1195
Test: I ran
shx --versionwith this copy of shelljs as the dependency