fix: Race condition when updating the distribution #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

horike37 merged 1 commit into serverless-operations:master from mAiNiNfEcTiOn:master

May 7, 2020

mAiNiNfEcTiOn commented May 6, 2020

What does this PR do

Fixes a race condition that happens when having 2 or more functions within the same CloudFront distribution.
Closes Getting 412 in between updateDistributions #3

Where should the reviewer start

I've basically changed only the index.js to be more async..await friendly


          fix: race condition when updating the distribution

40def6d

horike37 approved these changes

View reviewed changes

Contributor

horike37 left a comment

@mAiNiNfEcTiOn
Thanks for the fix 👍 Good catch.

horike37 merged commit 3a081ed into serverless-operations:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet