Add a callback on the reader options to expose the log level switches #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@0xced fyi i took the liberty of resolving a conflict |
SimonCropp
approved these changes
Mar 10, 2023
nblumhardt
reviewed
Mar 10, 2023
Member
nblumhardt
left a comment
There was a problem hiding this comment.
LGTM! Added some minor comments :-)
src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReaderOptions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Mar 11, 2023
sungam3r
reviewed
Mar 11, 2023
| } | ||
|
|
||
| public void AddFilterSwitch(string filterSwitchName, LoggingFilterSwitchProxy filterSwitch) | ||
| public string AddFilterSwitch(string filterSwitchName, LoggingFilterSwitchProxy filterSwitch) |
Contributor
There was a problem hiding this comment.
The result of this method is not used. Is it specially done?
Member
Author
There was a problem hiding this comment.
This was done in anticipation of #366 where the result is now used.
0xced
added a commit
to 0xced/serilog-settings-configuration
that referenced
this pull request
Mar 15, 2023
Just like it was done for log level switches in serilog#352.
0xced
added a commit
to 0xced/serilog-settings-configuration
that referenced
this pull request
May 5, 2023
Just like it was done for log level switches in serilog#352.
0xced
added a commit
to 0xced/serilog-settings-configuration
that referenced
this pull request
May 5, 2023
Just like it was done for log level switches in serilog#352.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206