Skip to content

Generate AssemblyVersionAttribute #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Generate AssemblyVersionAttribute #357

merged 1 commit into from
Jan 19, 2024

Conversation

@nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Jan 18, 2024

Fixes #356

@bartelink
Copy link
Member

bartelink commented Jan 18, 2024

clones? https://github.com/search?q=org%3Aserilog+GenerateAssemblyVersionAttribute&type=code

augustoproiete
augustoproiete approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nblumhardt nblumhardt merged commit 54f5749 into serilog:dev Jan 19, 2024
@nblumhardt
Copy link
Member Author

nblumhardt commented Jan 19, 2024

@bartelink great idea 👍 ... I think in the cases where false appears there, the project has a Properties/AssemblyInfo.cs file with a fixed version in it. We should ideally do away with that everywhere. Gearing up to start some "4.x" series changes soon :-)

@nblumhardt nblumhardt mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Serilog.AspNetCore v8.0.0 but assembly version 0.0.0.0

3 participants

@nblumhardt @bartelink @augustoproiete