Rewrite pull-secret-extractor in Go #3267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-securecodebox canceled.
|
J12934
requested changes
Sep 9, 2025
Member
J12934
left a comment
There was a problem hiding this comment.
nice, looks generally really good, got some notes / recommendation on some parts of the code :)
also of note: with this change we will also need to change the initContainer spec in the contaienr auto-discovery where this container is started, funciton in the auto-disc. is called: getSecretExtractionInitContainer
auto-discovery/kubernetes/pull-secret-extractor/internal/secret_extraction/secret_extraction.go
Outdated
Show resolved
Hide resolved
auto-discovery/kubernetes/pull-secret-extractor/internal/secret_extraction/secret_extraction.go
Outdated
Show resolved
Hide resolved
auto-discovery/kubernetes/pull-secret-extractor/internal/secret_extraction/secret_extraction.go
Outdated
Show resolved
Hide resolved
d2c5c5b to
5af142e
Compare
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick Weiss <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
4ea6a9d to
bf277ff
Compare
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
approved these changes
Sep 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(closes ⚙️ Maintanance Improvment: Move
auto-discoverypull-secret extractor to golang #2998)Checklist