Get versions correctly #2081
Merged
Get versions correctly #2081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b1bcfa to
af9e213
Compare
1f7dc03 to
f035f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Get versions correctly from packages.broadcom.com.
Previous Behavior
There was a problem when populating the major version entry in the dictionary. It would populate based on sorting which isn't always right as far as what is the latest version. It would always end at 3006.9 for example, even after 3006.15 was released.
New Behavior
Now it does some version comparison to actually update "latest" and "major_version" entries so they actually are the latest versions available.