Remove uses of spwd #68402
Open
Remove uses of spwd #68402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
Test failures appear not related to my patch, but let me know if I missed something. |
3 tasks
m-czernek
added a commit
to openSUSE/salt
that referenced
this pull request
Oct 30, 2025
Cherry-pick of saltstack/salt#68402
twangboy
approved these changes
Oct 31, 2025
Module deprecated and no longer shipped with Python 3.13. Co-authored-by: Toyam Cox <Vaelatern@voidlinux.org> Co-authored-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net> Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
meaksh
added a commit
to openSUSE/salt
that referenced
this pull request
Nov 7, 2025
* Do not use ConfigParser.readfp in nilrt_ip module * Use external tornado with newest Python * Migrate batch_async to external tornado * Mutating locals is unsupported in Py >=3.13 * modules/tls.py: Use cryptography for create_pkcs12 * modules/x509: Use cryptography for create_crl * Remove use of spwd, removed module in py3.13 * Fix issues around closing IOLoop * Fix error if future is already done * Fix io_loop closing in tpc.py and http.py Partial cherry-pick of c4677c6 * Remove unexpected callback keyword * Fix fileclient inability to download a file * Remove mentions of StackContext * Ensure current_ioloop works for vendored and ext tornado * Fix test_linux_shadow tests Cherry-pick of saltstack/salt#68402 * Test saltnado fail fix * Fix test_base_api_handler test * Fix tests_webhook_handler test * Fix salt fileclient for old and new tornado * Raise Python version for vendored tornado * Add compatibility with StackContext * Implement fixme in tls * Apply cosmetic suggestion Co-authored-by: Victor Zhestkov <vzhestkov@suse.com> --------- Co-authored-by: Alexander Graul <agraul@suse.com> Co-authored-by: Toyam Cox <Vaelatern@voidlinux.org> Co-authored-by: Pablo Suárez Hernández <psuarezhernandez@suse.com> Co-authored-by: Victor Zhestkov <vzhestkov@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Complete #67788 to remove spwd on Linux. Solaris parts are not touched as they already have compatibility for systems without spwd.
What issues does this PR fix or reference?
#67119
Previous Behavior
usermodule would fail withNameError: name 'spwd' is not definedon Python 3.13.New Behavior
usermodule works again.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes