fix: put this.hostElement behind API version 62
#4308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jun 19, 2024
| }, | ||
|
|
||
| get hostElement(): Element { | ||
| get hostElement(): Element | undefined { |
Contributor
Author
There was a problem hiding this comment.
Yes this makes the TypeScript types a bit more annoying (you have to do this.hostElement!) but I think the benefits to not shipping breaking changes makes it worth it.
nolanlawson
commented
Jun 19, 2024
ravijayaramappa
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
It occurred to me that it's kind of strange for the release notes to say "
this.styleis only available in API version 62 due to possible breaking changes, butthis.hostElementis available regardless." It's more consistent to just put both of them behind API versioning.Plus, this way we don't have to worry about potential breaking changes on the off-change that someone has already squatted
this.hostElement.Related: #4259
Does this pull request introduce a breaking change?
No, we haven't released
this.hostElementyet.Does this pull request introduce an observable change?